Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Delay when inputting key events through input method on android 14 #1237

Conversation

sds100
Copy link
Collaborator

@sds100 sds100 commented Jun 25, 2024

Closes #1218

@sds100 sds100 added the bug Something isn't working label Jun 25, 2024
@sds100 sds100 added this to the Version 2.6 milestone Jun 25, 2024
@sds100 sds100 self-assigned this Jun 25, 2024
@sds100 sds100 linked an issue Jun 25, 2024 that may be closed by this pull request
2 tasks
@sds100 sds100 merged commit bca5053 into develop Jun 30, 2024
2 checks passed
@sds100 sds100 deleted the 1218-delay-when-inputting-key-events-through-input-method-on-android-14 branch July 1, 2024 09:12
@dessalines
Copy link

Would be good to do another release with this included.

@sds100
Copy link
Collaborator Author

sds100 commented Sep 4, 2024

@dessalines I just sent this to google play for review. Can you test that it works in version 2.6.1 in github releases?

@dessalines
Copy link

Sorry, was on vacation. Yep I've verified that 2.6.2 works well!


val chars = text.toCharArray(startIndex = 0, endIndex = 1)

val events: Array<KeyEvent> = keyCharacterMap.getEvents(chars)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this one fall back to the other method? Asking because I'm getting nulls here when trying to input an á, but, at the same time, I can input áá.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create an issue so I don't miss this?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, OK: #1328

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Delay when inputting key events through input method on Android 14
3 participants