Clean up small cross-dependency between KsApiTests and Library #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1497,7 +1497,6 @@ | |||
| E1AA8ABF2AEABBB100AC98BF /* Signal+Combine.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1EA34EE2AE1B28400942A04 /* Signal+Combine.swift */; }; | |||
| E1BB25642B1E81AA000BD2D6 /* Publisher+Service.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1BB25632B1E81AA000BD2D6 /* Publisher+Service.swift */; }; | |||
| E1EEED292B684AA7009976D9 /* PKCE.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1EEED282B684AA7009976D9 /* PKCE.swift */; }; | |||
| E1FDB1E82AEAAC6100285F93 /* CombineTestObserver.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1FDB1E72AEAAC6100285F93 /* CombineTestObserver.swift */; }; | |||
There was a problem hiding this comment.
Xcode did this automatically; unclear why, but nothing has changed with this file. 🤷♀️ I've seen this happen on occasion, I think it just cleans up dead references.
| @@ -6670,7 +6670,6 @@ | |||
| D01587E41EEB2ED7006E7684 /* RewardsItem.swift */, | |||
| D01587E51EEB2ED7006E7684 /* RewardsItemTests.swift */, | |||
| D01587E61EEB2ED7006E7684 /* RewardTests.swift */, | |||
| 60AE9F022ABB822300FB3A96 /* ReportProjectInfoListItem.swift */, | |||
There was a problem hiding this comment.
This has already been moved to Library; I'm just moving the file to reflect that since it was still under KsApi.
amy-at-kickstarter
changed the title
ifosli
approved these changes
Feb 1, 2024
amy-at-kickstarter
force-pushed
the
feat/adyer/cleanup-circular-dependency
branch
from
81670f3 to
056ae7b
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
GraphSchemaTestsis part ofKsApiTestsand should have no knowledge ofLibraryReportProjectInfoListItem.swiftthat was no longer part of KsApi into Library, where it was already a target member🤔 Why
I discovered these two tiny issues while doing other investigation. I don't believe this PR actually solves any of the linker issues, but I think it's good discipline to keep these distinctions neater.