Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clean up small cross-dependency between KsApiTests and Library #1929

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Clean up small cross-dependency between KsApiTests and Library #1929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98a72a1
Remove Library import from GraphSchemaTests
amy-at-kickstarter Feb 1, 2024
056ae7b
Move ReportProjectInfoListItem into Library (where it was already a m…
amy-at-kickstarter Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Kickstarter.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1497,7 +1497,6 @@
E1AA8ABF2AEABBB100AC98BF /* Signal+Combine.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1EA34EE2AE1B28400942A04 /* Signal+Combine.swift */; };
E1BB25642B1E81AA000BD2D6 /* Publisher+Service.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1BB25632B1E81AA000BD2D6 /* Publisher+Service.swift */; };
E1EEED292B684AA7009976D9 /* PKCE.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1EEED282B684AA7009976D9 /* PKCE.swift */; };
E1FDB1E82AEAAC6100285F93 /* CombineTestObserver.swift in Sources */ = {isa = PBXBuildFile; fileRef = E1FDB1E72AEAAC6100285F93 /* CombineTestObserver.swift */; };
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xcode did this automatically; unclear why, but nothing has changed with this file. 🤷‍♀️ I've seen this happen on occasion, I think it just cleans up dead references.

/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
Expand Down Expand Up @@ -6015,6 +6014,7 @@
A7DC83951C9DBBE700BB2B44 /* RefTag.swift */,
A7ED1F1E1E830FDC00BFFA01 /* RefTagTests.swift */,
19A666622A0472C700708F8B /* RemoteConfig */,
60AE9F022ABB822300FB3A96 /* ReportProjectInfoListItem.swift */,
D7ADDFE522E0DAEB00157D83 /* RewardCellProjectBackingStateType.swift */,
D7180BA022EF9DD900EB0110 /* RewardCellProjectBackingStateTypeTests.swift */,
0169F8C01D6CA27500C8D5C5 /* RootCategory.swift */,
Expand Down Expand Up @@ -6670,7 +6670,6 @@
D01587E41EEB2ED7006E7684 /* RewardsItem.swift */,
D01587E51EEB2ED7006E7684 /* RewardsItemTests.swift */,
D01587E61EEB2ED7006E7684 /* RewardTests.swift */,
60AE9F022ABB822300FB3A96 /* ReportProjectInfoListItem.swift */,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has already been moved to Library; I'm just moving the file to reflect that since it was still under KsApi.

D6AE52261FD1B41200BEC788 /* RootCategoriesEnvelope.swift */,
D01587E71EEB2ED7006E7684 /* ShippingRule.swift */,
D01587E81EEB2ED7006E7684 /* ShippingRulesEnvelope.swift */,
Expand Down
2 changes: 0 additions & 2 deletions KsApi/GraphSchemaTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
@testable import KsApi
@testable import Library
import Prelude
import XCTest

class GraphSchemaTests: XCTestCase {
Expand Down
0 KsApi/models/ReportProjectInfoListItem.swift → Library/ReportProjectInfoListItem.swift
View file
Open in desktop
File renamed without changes.