[MBL-1613] Handle errors for late pledges without dismissing the view controller #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
force-pushed
the
removeConfirmDetailsErrorHandling
branch
from
ad875bf to
5ec631f
Compare
scottkicks
approved these changes
Oct 14, 2024
| @@ -34,12 +34,11 @@ public protocol NoShippingPostCampaignCheckoutViewModelOutputs { | |||
| var goToLogin#: Signal<(LoginIntent, Project, Reward), Never> { get } | |||
| var paymentMethodsViewHidden: Signal<Bool, Never> { get } | |||
| var processingViewIsHidden: Signal<Bool, Never> { get } | |||
| var showErrorBannerWithMessage: Signal<String, Never> { get } | |||
| var showErrorBannerWithMessage: Signal<(String, /* persist: */ Bool), Never> { get } | |||
There was a problem hiding this comment.
nit: Adding parameter names instead of an inline comment might clarify that this output has the option to persist.
There was a problem hiding this comment.
Oh cool! Updated! TIL that swift allows you to name fields in a tuple (obj-c does not!)
stevestreza-ksr
pushed a commit
that referenced
this pull request
Oct 16, 2024
… controller (#2171) * Fix late pledge error handling * Use named tuple fields for error banner
4 tasks
scottkicks
added a commit
that referenced
this pull request
Dec 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Handle errors in the late pledge flow without a confirm details page by just showing an error banner (not dismissing the vc). The error banner will persist if the error happens when creating the checkout. If it's an error that happens in a part of the flow the user can retry (after hitting "pledge" or adding a new card) the banner disappears.
👀 See
Jira
✅ Acceptance criteria