[MBL-1905] Revert "[MBL-1613]" #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottkicks
requested review from
ifosli,
a team and
stevestreza-ksr
and removed request for
a team
ifosli
approved these changes
Dec 3, 2024
| @@ -456,7 +457,6 @@ public class NoShippingPostCampaignCheckoutViewModel: NoShippingPostCampaignChec | |||
|
|
|||
| let completeCheckoutWithCreditCardInput: Signal<GraphAPI.CompleteOnSessionCheckoutInput, Never> = Signal | |||
| .combineLatest(self.confirmPaymentSuccessfulProperty.signal.skipNil(), checkoutId, selectedCard) | |||
| .takeWhen(self.confirmPaymentSuccessfulProperty.signal.skipNil()) | |||
There was a problem hiding this comment.
I think we should still keep this takeWhen - it's probably not needed since a user shouldn't be able to change the selected card again once we dismiss this vc if checkout fails, but having "change selected card" kick off checkout is not a risk I'd like to take.
stevestreza-ksr
approved these changes
Dec 4, 2024
| .observeValues { [weak self] error in | ||
|
|
||
| #if DEBUG | ||
| let serverError = error.errorMessages.first ?? "" |
There was a problem hiding this comment.
Nit: Maybe put a default value (Unknown server error or something) instead of an empty string here, since this is for debugging
ifosli
approved these changes
Dec 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Reverts #2171
🤔 Why
As our estimated shipping flag has been rolling out, a backer experienced an error when attempting to late pledge with Apple Pay. They were shown an error banner and weren't able to retry their pledge.
This looks to be an error where re-creating a payment intent is failing because some backend state changed.
See original thread between mobile and payments for more context: https://kickstarter.slack.com/archives/C3LS41US0/p1732652825528529
🛠 How
By reverting these changes, the checkout screen will dismiss forcing a new checkout object to be created for the user so that a new payment intent can be created and validated when there is an error like this.
✅ Acceptance criteria
Tested this by manually forcing validate checkout and onCompleteSessionCheckout to fail on Staging. Testing the Apple Pay flow on Prod to verify that is working as expected will be important also.
⏰ TODO