Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Link Tracking counts multiple clicks from the same user multiple times #522

Closed
NicoHood opened this issue Oct 19, 2021 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@NicoHood
Copy link
Contributor

Version:

  • listmonk: 2.0.0
  • OS: Uberspace webhosting (I dont know the OS)

Description of the bug and steps to reproduce:

  • Insert a tracking link
  • Click on that link from the same user twice

Screenshots:
In the screenshot you can see, that my newsletter with 3 people shows that 2 clicked on the button. But actually one guy clicked twice.
image

I am not sure if just the displaying UI is wrong or only one tracking link for all is generated. The link should be individual to correctly track the clicks.

@NicoHood NicoHood added the bug Something isn't working label Oct 19, 2021
@knadh knadh removed the bug Something isn't working label Oct 19, 2021
@knadh
Copy link
Owner

knadh commented Oct 19, 2021

It is the total count of clicks, no the count of unique subscribers. If a user clicks on a link multiple times, or if a user forwards an e-mail to others and they click on the links, they're all valid clicks. It might make sense to add a "unique" filter to reports, but it isn't available currently.

@knadh knadh closed this as completed Oct 19, 2021
@NicoHood
Copy link
Contributor Author

NicoHood commented Oct 19, 2021

Alright, could you maybe reopen the issue and tag it as feature request then?

What is confusing to me is the percent visual. It will confuse people, as the % can be over 100% (even though it is not displayed).
image

So maybe the visual should be corrected?

@knadh
Copy link
Owner

knadh commented Jan 25, 2022

Closing this in favour of #676.

@knadh knadh closed this as completed Jan 25, 2022
knadh added a commit that referenced this issue Feb 1, 2022
The analytics page showed non-unique counts for views and clicks which
was misleading and source of confusion: #522, #561, #571, #676, #680
This commit changes this behaviour to pull unique views and clicks when
individual subscriber tracking is turned on in settings, and non-unique
counts when it is turned off (as `subscriber_id` in `campaign_views`
and `link_clicks` will be NULL, rendering unique queries dysfunctional).

This commit changes the stats SQL queries to use string interpolation
to either to SELECT `*` or `DISTINCT subscriber_id` on app boot based
on the setting in the DB. This involves significant changes to how
queries are read and prepared on init.

- Refactor `initQueries()` to `readQueries()` and `prepareQueries()`.
- Read queries first before preparing.
- Load settings from the DB using the read settings query.
- Prepare queries next. Use the privacy setting from the DB to apply
  string interpolation to the analytics queries to pull
  unique/non-unique before preparing the queries.

On the UI:
- Show a note on the analytics page about unique/non-unique counts.
- Hide the % donut charts on the analytics page in non-unique mode.

Closes #676, closes #680
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants