Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Campaign view statistics counts multiple times per user #561

Closed
NicoHood opened this issue Oct 29, 2021 · 3 comments
Closed

Campaign view statistics counts multiple times per user #561

NicoHood opened this issue Oct 29, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@NicoHood
Copy link
Contributor

NicoHood commented Oct 29, 2021

Version:

  • listmonk: 2.0.0

Description of the bug and steps to reproduce:
Similar to #522 the statistics for campaign views count multiple times per user, making it absolutely useless for me. If i just click the email on my inbox, click on another item and then back, it counts as opened 3 times. It does not count how many people actually read the email.

grafik

@NicoHood NicoHood added the bug Something isn't working label Oct 29, 2021
@knadh knadh added enhancement New feature or request and removed bug Something isn't working labels Oct 29, 2021
@knadh
Copy link
Owner

knadh commented Oct 29, 2021

Like #522, not a bug, but a different kind of view. A "unique" filter might be useful here.

@NicoHood
Copy link
Contributor Author

Yes, please :-)

@knadh
Copy link
Owner

knadh commented Jan 25, 2022

Closing this in favour of #676.

@knadh knadh closed this as completed Jan 25, 2022
knadh added a commit that referenced this issue Feb 1, 2022
The analytics page showed non-unique counts for views and clicks which
was misleading and source of confusion: #522, #561, #571, #676, #680
This commit changes this behaviour to pull unique views and clicks when
individual subscriber tracking is turned on in settings, and non-unique
counts when it is turned off (as `subscriber_id` in `campaign_views`
and `link_clicks` will be NULL, rendering unique queries dysfunctional).

This commit changes the stats SQL queries to use string interpolation
to either to SELECT `*` or `DISTINCT subscriber_id` on app boot based
on the setting in the DB. This involves significant changes to how
queries are read and prepared on init.

- Refactor `initQueries()` to `readQueries()` and `prepareQueries()`.
- Read queries first before preparing.
- Load settings from the DB using the read settings query.
- Prepare queries next. Use the privacy setting from the DB to apply
  string interpolation to the analytics queries to pull
  unique/non-unique before preparing the queries.

On the UI:
- Show a note on the analytics page about unique/non-unique counts.
- Hide the % donut charts on the analytics page in non-unique mode.

Closes #676, closes #680
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants