Reverse broadcast order #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the broadcast() method is called from within a ListenEtherSwitch, dumping the packet to the “listen” port last may cause inconsistencies when e.g. attaching this port to a ToDump. Because of the packet processing, this causes e.g. the first ARP reply to appear in the dump file before the ARP request. Dumping the packet to the listen port first fixes this issue.
|
Nice and clear, thanks for the patch! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the broadcast() method is called from within a ListenEtherSwitch, dumping the packet to the “listen” port last may cause inconsistencies when attaching this port to a ToDump. Because of the packet processing order, this causes e.g. the first ARP reply to appear in the dump file before the ARP request. Broadcasting the packet to the listen port first fixes this issue.