click/etherswitch: Forward traffic to a set of ports #334
Conversation
|
@tbarbette Could you take a look at this one and comment or commit to mainline? |
elements/etherswitch/etherswitch.cc
Outdated
| .read("TIMEOUT", SecondsArg(), _timeout) | ||
| .complete(); | ||
| .complete() < 0) | ||
| return errh->error("bad timeout"); |
There was a problem hiding this comment.
Just return -1. The error could be that there is an unknown argument, not bad timeout. In both ease read and complete will already add the error msg.
|
Apart from the small comment it looks good to me. I just wonder about the performance impact? It is a fast-path element and that may effect a lot of peoples. This adds at least two indirections per packets. I don't merge non-DPDK related commits myself. @kohler will probably have thoughts about this anyway. |
|
I like the concept of this element and find the functionality useful. But agree that it would be preferred to have it as a separate element. Also, I had some issues compiling in userlevel due to some errors related to bitvector functions. It was related to the weight if I recall correctly. Another little nitpick, it would be nice to have the usage example in the header vs git comment. |
|
I tried to generate multiple L2 flows (1-256) to evaluate the performance impact of this element but I could not see any clear impact. I guess this make a very slow path (after all broadcasts are not the usual) just a little bit heavier, so at the end, it is not that much of a problem. @SDarayan I've re-imported the dependencies in tbarbette/click in https://github.com/tbarbette/click/tree/fixdeps , you would need to include those I agree with the usage in the header. I can see where the practice come from :p |
Signed-off-by: Patrick Verkaik <pverkaik@meraki.com>
Returns the number of bits equal to one
Bitvector::parse(str, min_val, max_val, offset = 0)
parses a comma separated list of values and dashed value ranges into
the bitvector.
'min_val' and 'max_val' are the minimum and maximum values allowed
during parsing. 'offset' pads out extra false bits at the beginning
of the bitvector before the bit corresponding to 'min_val'. Setting
'offset' to 1 can be used to create one based indexing.
Examples:
parse("1,3,5-8", 1, 10) -> 1010111100
parse("1,3", 1, 3, 3) -> 000101
parse("-5,-2--1", -5, 0) -> 100110
Bitvector::unparse(read_offset = 0, output_offset = 0)
outputs a string representing the set bits in the bitvector.
11010.unparse() -> "0-1,3"
A positive 'read_offset' skips the specified number of bits and
decreases the output values the same number:
11010.unparse(1) -> "0,2"
A negative 'read_offset' pads the output with the specified number of
unset bits (this is the same as just increasing output_offset the same amount):
11010.unparse(-1) -> "1-2,4"
'output_offset' increases or decreases the output values:
11010.unparse(0, 1) -> "1-2,4"
11010.unparse(0, -1) -> "-1-0,2"
Reviewed-by: jparks@meraki.com
Signed-off-by: Patrick Verkaik <pverkaik@meraki.com>
The default behavior of etherswitch is to forward traffic to all ports except the source when broadcast or to the destination port found in lookup of etherswitch's mac table. This commit expands the functionality of etherswitch to send packet(s) out port(s) iff the port to forward traffic is enabled. Thus, etherswitch can selectively forward traffic to particular ports, a feature proving useful with broadcast traffic so as to avoid traffic loops between click and other external hardware (e.g. switch). Ports can selectively be removed and the port forwarding map can be reset via write handlers "remove_port_forwarding" and "reset_port_forwarding". The arguments to "remove_port_forwarding" write handler is a list of numbers with the first one being a source port and the others being ports to remove. For example, "1 2 3 4, 2 3 4" means port 1 will not forward traffic to ports 2, 3, and 4 -- in addition port 2 will not forward traffic to ports 3 and 4. No arguments are necessary for "reset_port_forwarding" write handler. Also, the port forwarding map can be viewed via read handler "port_forwarding".
|
@tbarbette @SDarayan does this not reintroduce issue #327 |
The default behavior of etherswitch is to forward traffic
to all ports except the source when broadcast or to the
destination port found in lookup of etherswitch's mac table.
This commit expands the functionality of etherswitch to
send packet(s) out port(s) iff the port to forward traffic
is enabled. Thus, etherswitch can selectively forward traffic
to particular ports, a feature proving useful with broadcast
traffic so as to avoid traffic loops between click and other
external hardware (e.g. switch).
Ports can selectively be removed and the port forwarding map
can be reset via write handlers "remove_port_forwarding" and
"reset_port_forwarding".
The arguments to "remove_port_forwarding" write handler is a
list of numbers with the first one being a source port and
the others being ports to remove.
For example, "1 2 3 4, 2 3 4" means port 1 will not forward
traffic to ports 2, 3, and 4 -- in addition port 2 will not
forward traffic to ports 3 and 4.
No arguments are necessary for "reset_port_forwarding" write
handler.
Also, the port forwarding map can be viewed via read handler
"port_forwarding".