✨ Support extenion compat with addon as regex. #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
1 task
jortel
commented
Feb 11, 2025
| @@ -368,6 +368,7 @@ func (r *Hub) namespace() (ns string, err error) { | |||
| // build returns the hub build version. | |||
| // This is expected to be the output of `git describe`. | |||
| // Examples: | |||
| // | |||
There was a problem hiding this comment.
hint: ^ added by gofmt.
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
jortel
added a commit
that referenced
this pull request
Feb 12, 2025
Missed a validation in #782. Signed-off-by: Jeff Ortel <jortel@redhat.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the analyzer and tech-discovery both use the same providers. An extension having compatibility with multiple addons is not a common/mainstream use case. To get around this, we have defined a duplicate set of extensions for each provider. One with compatibility with the
analyzeraddon and the other for thetech-discoveryaddon.After a recent refactor of the generic extension into multiple extensions (go, python, nodejs), it became obvious that maintain the duplicate set of extensions is painful and likely error prone.
It seems a better approach is to change
Extention.Spec.Addonto (optionally) define a regex. This approach caters to the mainstream use case that extensions have compatibility with one addon. It also avoids making the field an array requiring a CRD change. This is which is MUCH simpler.The existing extensions will need to be updated to be compatible with both addons.
Example (java extension):
The
discovery-extensions would be deleted.