🐛 Extension addon (ref) regex fix. #783
Merged
+32
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <jortel@redhat.com>
jortel
commented
Feb 12, 2025
| } | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
hint: ^ moved to Task for better reuse.
jortel
commented
Feb 12, 2025
| @@ -1361,7 +1337,12 @@ func (r *Task) Run(cluster *Cluster) (started bool, err error) { | |||
| return | |||
| } | |||
| for _, extension := range extensions { | |||
| if r.Addon != extension.Spec.Addon { | |||
| matched := false | |||
| matched, err = r.matchAddon(&extension, addon) | |||
There was a problem hiding this comment.
hint: Missed this validation in the original PR.
jortel
commented
Feb 12, 2025
| @@ -1620,7 +1601,7 @@ func (r *Task) podFailed(pod *core.Pod, client k8s.Client) { | |||
| } | |||
| } | |||
|
|
|||
| // getExtensions by name. | |||
| // getExtensions returns defined extensions. | |||
There was a problem hiding this comment.
hint: incidental. noticed it was incorrect.
aufi
approved these changes
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed a validation in #782.