Fix Node 20.12.2 child_process.spawn .cmd EINVAL on Windows #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longzheng
commented
Apr 30, 2024
| @@ -34,7 +34,8 @@ $SCRYPTED_HOME_ESCAPED_PATH = $SCRYPTED_HOME.replace('\', '\\') | |||
| npm install --prefix $SCRYPTED_HOME @koush/node-windows --save | |||
|
|
|||
| $NPX_PATH = (Get-Command npx).Path | |||
| $NPX_PATH_ESCAPED = $NPX_PATH.replace('\', '\\') | |||
| # The path needs double quotes to handle spaces in the directory path | |||
| $NPX_PATH_ESCAPED = `"${$NPX_PATH.replace('\', '\\')}"` | |||
There was a problem hiding this comment.
I'm guessing because it's running as a service it needs the full path since it doesn't have the npm directory in the Path environment variable?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1453 incompatibility with Node 20.12.2 on Windows. https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2
I looked for all usages of
child_process.spawnwhich invoked a.cmdfile and addedshell: true(conditionally since I didn't want to change non-Windows behavior)I also wrapped the
NPX_PATH_ESCAPEDbecause the path will contain spaces e.g.C:\\Program Files\\nodejs\\npx.cmdwhich doesn't work withshell: trueThere were other usages of
child_process.spawnwhich were forffmpegandffplaywhich I don't think needs any change since those are.exefiles.