Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Windows server install with installDir containing space #1471

Merged
merged 3 commits into from
May 15, 2024

Conversation

longzheng
Copy link
Contributor

Addresses issue with installing on Windows when the user profile directory contains a path, e.g. C:\Users\john doe https://discord.com/channels/882329362295316500/1237486685030322176/1238683790562431066

The child_process.spawn with shell: true (required for Node 20.12.2 on Windows) would fail if there are spaces in the path

@longzheng longzheng changed the title Fix server install with installDir containing space Fix Windows server install with installDir containing space May 11, 2024
@longzheng
Copy link
Contributor Author

Examples

C:\Users\john doe>npx -y scrypted install-server
install-server version: undefined
running npm.cmd "--prefix" "C:\Users\john doe\.scrypted" "install" "--production" "@scrypted/server@latest"
C:\Users\john doe>npx -y scrypted serve
cwd C:\Users\john doe\.scrypted
Starting scrypted main...
running npm.cmd "--prefix" "C:\Users\john doe\.scrypted" "exec" "scrypted-serve"

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants