Downgrade yaml version to avoid indentations #2117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanimarupaka
force-pushed
the
YamlVersion
branch
from
9f3939f to
bc9d849
Compare
|
what is going on with all the comments being deleted from expected? Are we trading one bug for another? |
6 tasks
|
I'm not sure rolling back to a different version is an option here. We are relying on several bugfixes in the new version and we can't really end up being stuck on the old version forever. The change to v1 seems like the best opportunity we have to make this change, despite the challenges. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to downgrade yaml library version(match it with 0.39.0 kpt) so that the indentation formatting is consistent with kubernetes examples and existing packages to avoid unwanted diffs.
Coming up PRs: