Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] Localize The Quit Modal to russian #997

Closed
kreghek opened this issue Jan 11, 2021 · 4 comments · Fixed by #1026, #1065, #1066, #1067 or #1068
Closed

[BUG] Localize The Quit Modal to russian #997

kreghek opened this issue Jan 11, 2021 · 4 comments · Fixed by #1026, #1065, #1066, #1067 or #1068
Assignees
Labels
bug Something isn't working client Works on client release-significant This merge request will log into release notes

Comments

@kreghek
Copy link
Owner

kreghek commented Jan 11, 2021

Describe the bug
The Quit Modal shows different phrases. They are only on english.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Quit button.
  2. See only english phrases.

Expected behavior
All text must showed in current ui culture.

Additional context
Plan:

  1. Add text resources for each culture. Each phrase in different line.
  2. Read all phrases from text resource depending current culture.
  3. Select random line.
@kreghek kreghek added bug Something isn't working client Works on client labels Jan 11, 2021
@kreghek kreghek added this to the 2.4.7 Client auto-play mode milestone Jan 11, 2021
@kreghek kreghek self-assigned this Jan 11, 2021
@kreghek
Copy link
Owner Author

kreghek commented Feb 14, 2021

Reproduced after merge
https://github.com/kreghek/Zilon_Roguelike/actions/runs/565980540#artifacts

It wasn't work at all for build.

@kreghek kreghek reopened this Feb 14, 2021
@kreghek kreghek added the release-significant This merge request will log into release notes label Feb 14, 2021
@kreghek
Copy link
Owner Author

kreghek commented Feb 16, 2021

Logs of the Unity player

RuntimeData is null.  Please ensure you have built the correct Player Content. 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

Addressables - Unable to load runtime data at location UnityEngine.ResourceManagement.AsyncOperations.AsyncOperationHandle`1[[UnityEngine.AddressableAssets.Initialization.ResourceManagerRuntimeData, Unity.Addressables, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null]]. 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

Exception encountered in operation InitializationOperation, status=Failed, result= : Addressables - Unable to load runtime data at location UnityEngine.ResourceManagement.AsyncOperations.AsyncOperationHandle`1[[UnityEngine.AddressableAssets.Initialization.ResourceManagerRuntimeData, Unity.Addressables, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null]]. 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

Exception encountered in operation CompletedOperation, status=Failed, result= : Exception of type 'UnityEngine.AddressableAssets.InvalidKeyException' was thrown., Key=Locale, Type=UnityEngine.Localization.Locale 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

Exception encountered in operation ChainOperation<IList`1> - InitializationOperation, status=Failed, result= : ChainOperation of Type: System.Collections.Generic.IList`1[UnityEngine.Localization.Locale] failed because dependent operation failed
Exception of type 'UnityEngine.AddressableAssets.InvalidKeyException' was thrown., Key=Locale, Type=UnityEngine.Localization.Locale 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 35)

No Locale could be selected:
No Locales were available. Did you build the Addressables?
The following (3) IStartupLocaleSelectors were used:
	UnityEngine.Localization.Settings.CommandLineLocaleSelector
	UnityEngine.Localization.Settings.SystemLocaleSelector
	UnityEngine.Localization.Settings.SpecificLocaleSelector

@kreghek
Copy link
Owner Author

kreghek commented Mar 16, 2021

@kreghek
Copy link
Owner Author

kreghek commented Mar 19, 2021

Possible solution
game-ci/unity-builder#230 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment