Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix 997 localization recreate 2 #1065

Merged
merged 31 commits into from
Mar 22, 2021
Merged

Conversation

kreghek
Copy link
Owner

@kreghek kreghek commented Mar 22, 2021

Resolves #997

Changes

  • Fix localization/addressables build

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@kreghek kreghek added bug Something isn't working client Works on client labels Mar 22, 2021
@kreghek kreghek self-assigned this Mar 22, 2021
kreghek added 2 commits March 22, 2021 21:57
…alization-recreate-2

# Conflicts:
#	.github/workflows/mutation-test-stryker.yml
#	Zilon.Client/Packages/manifest.json
#	Zilon.Client/ProjectSettings/EditorBuildSettings.asset
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #1065 (3a858d3) into master (6283348) will increase coverage by 0.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage   76.81%   77.57%   +0.75%     
==========================================
  Files         345      345              
  Lines        7946     7946              
==========================================
+ Hits         6104     6164      +60     
+ Misses       1842     1782      -60     
Flag Coverage Δ
Zilon.Core.FunctionalTests 69.36% <ø> (+3.59%) ⬆️
Zilon.Core.UnitTests 47.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n.Core/Zilon.Bot.Players/Logics/SelectActHelper.cs 74.07% <0.00%> (-18.52%) ⬇️
...on.Core/Zilon.Bot.Players/Logics/LootLogicState.cs 89.13% <0.00%> (-4.35%) ⬇️
...ilon.Core/Zilon.Core/Tactics/Behaviour/MoveTask.cs 88.46% <0.00%> (-1.93%) ⬇️
Zilon.Core/Zilon.Core/Tactics/Actor.cs 53.64% <0.00%> (-1.33%) ⬇️
...lon.Core/PersonGeneration/FullPersonFactoryBase.cs 84.61% <0.00%> (-0.97%) ⬇️
...on.Core/Zilon.Core/Tactics/ActorActUsageHandler.cs 84.16% <0.00%> (-0.46%) ⬇️
...pGenerators/RoomStyle/RoomGeneratorRandomSource.cs 72.83% <0.00%> (+4.93%) ⬆️
...Zilon.Core/Tactics/TacticalActUsageRandomSource.cs 80.00% <0.00%> (+5.00%) ⬆️
...Core/MapGenerators/MonsterGeneratorRandomSource.cs 100.00% <0.00%> (+5.00%) ⬆️
...on.Core/Zilon.Bot.Players/Logics/ExitLogicState.cs 90.62% <0.00%> (+6.25%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6283348...3a858d3. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kreghek kreghek merged commit 5142fb5 into master Mar 22, 2021
@kreghek kreghek deleted the fix-997-localization-recreate-2 branch March 22, 2021 15:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working client Works on client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Localize The Quit Modal to russian
1 participant