Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use Unity Localization build-in mechanism #1026

Merged
merged 9 commits into from
Feb 14, 2021

Conversation

kreghek
Copy link
Owner

@kreghek kreghek commented Feb 14, 2021

Now we can localized content using Unity Localization.

Resolves #997

@kreghek kreghek added code improvement Улучшение метрик кодовой базы client Works on client labels Feb 14, 2021
@kreghek kreghek added this to the 2.4.7 Client auto-play mode milestone Feb 14, 2021
@kreghek kreghek self-assigned this Feb 14, 2021
@kreghek kreghek added the release-significant This merge request will log into release notes label Feb 14, 2021
@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #1026 (f0a4354) into master (00d4c1c) will increase coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
+ Coverage   76.43%   77.16%   +0.73%     
==========================================
  Files         344      344              
  Lines        7655     7655              
==========================================
+ Hits         5851     5907      +56     
+ Misses       1804     1748      -56     
Flag Coverage Δ
Zilon.Core.FunctionalTests 66.80% <ø> (+0.91%) ⬆️
Zilon.Core.UnitTests 46.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ore/Zilon.Bot.Players/Logics/HealSelfLogicState.cs 66.66% <0.00%> (-8.34%) ⬇️
...Bot.Players/Triggers/LowHpAndHasResourceTrigger.cs 83.33% <0.00%> (-4.17%) ⬇️
Zilon.Core/Zilon.Core/Tactics/Actor.cs 51.35% <0.00%> (-2.03%) ⬇️
...on.Core/Zilon.Core/Tactics/ActorActUsageHandler.cs 82.21% <0.00%> (+0.48%) ⬆️
....Core/Zilon.Core/Persons/EquipmentCarrierHelper.cs 85.33% <0.00%> (+1.33%) ⬆️
...lon.Core/PersonGeneration/FullPersonFactoryBase.cs 88.88% <0.00%> (+2.02%) ⬆️
...on.Core/Zilon.Core/MapGenerators/ChestGenerator.cs 93.93% <0.00%> (+3.03%) ⬆️
....Core/PersonGeneration/RandomHumanPersonFactory.cs 100.00% <0.00%> (+3.70%) ⬆️
Zilon.Core/Zilon.Core/Tactics/HitHelper.cs 77.77% <0.00%> (+5.55%) ⬆️
...on.Core/Zilon.Bot.Players/Logics/ExitLogicState.cs 90.62% <0.00%> (+6.25%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d4c1c...f0a4354. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kreghek kreghek merged commit de1815f into master Feb 14, 2021
@kreghek kreghek deleted the feature-use-unity-localization branch February 14, 2021 13:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
client Works on client code improvement Улучшение метрик кодовой базы release-significant This merge request will log into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Localize The Quit Modal to russian
1 participant