Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix links in comments to filters API #3492

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

chipzoller
Copy link
Collaborator

Signed-off-by: chipzoller chipzoller@gmail.com

What does this PR change?

Fixes broken links in comments.

Does this PR rely on any other PRs?

No

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Gives them accessible links.

Links to Issues or tickets this PR addresses or fixes

Fixes #3473

What risks are associated with merging this PR? What is required to fully test this PR?

None

How was this PR tested?

Links validated.

Have you made an update to documentation? If so, please provide the corresponding PR.

N/A

Signed-off-by: chipzoller <chipzoller@gmail.com>
Copy link
Collaborator

@jessegoodier jessegoodier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@chipzoller chipzoller merged commit a0779ad into kubecost:develop Jun 20, 2024
15 checks passed
@chipzoller chipzoller deleted the cz-filters-api branch June 20, 2024 12:52
@chipzoller
Copy link
Collaborator Author

/cherry-pick v2.3

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 20, 2024
Signed-off-by: chipzoller <chipzoller@gmail.com>
chipzoller added a commit that referenced this pull request Jun 20, 2024
Signed-off-by: chipzoller <chipzoller@gmail.com>
Co-authored-by: Chip Zoller <chipzoller@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Broken link in values comment
2 participants