Update images #234
Update images #234
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
is this ready? @xing-yang |
|
/assign @yuxiangqian |
|
I'll need to update the image to 2.0.1. |
xing-yang
force-pushed
the
update_images_v2.0.0
branch
from
fbabdb2 to
2bde75f
Compare
|
@yuxiangqian updated the image to 2.0.1. PTAL. |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
xing-yang
force-pushed
the
update_images_v2.0.0
branch
from
2bde75f to
5d72243
Compare
| @@ -72,7 +72,7 @@ spec: | |||
| serviceAccount: csi-snapshotter | |||
| containers: | |||
| - name: csi-provisioner | |||
| image: quay.io/k8scsi/csi-provisioner:v1.5.0-rc1 | |||
| image: quay.io/k8scsi/csi-provisioner:v1.5.0 | |||
There was a problem hiding this comment.
In the other repos, we use "latest" tag so we don't need to remember to update it every release
There was a problem hiding this comment.
Sure. I want to backport this to release-2.0 branch. Do you suggest to submit a PR directly to the release-2.0 branch?
There was a problem hiding this comment.
I guess this is a strange example because in other sidecar repos, the deployment is not a complete/workable spec and the expectation is to go to the hostpath driver repo to look at a real example with fixed versions
There was a problem hiding this comment.
We want to provide an example here so people can test create snapshot easily without deploying a full blown setup as in the hostpath driver repo. I can add a note here for people to look at that repo for full testing of all features.
|
This is fine but I'm concerned about future maintenance burden to remember to update this every single release. |
k8s-ci-robot
added
the
lgtm
984feec Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e605 fixed broken links of testgrid dashboard git-subtree-dir: release-tools git-subtree-split: 984feec
984feec Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e605 fixed broken links of testgrid dashboard git-subtree-dir: release-tools git-subtree-split: 984feec
984feec Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e605 fixed broken links of testgrid dashboard git-subtree-dir: release-tools git-subtree-split: 984feec
fixed broken links of testgrid dashboard
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR updates images.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: