Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update images #234

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Update images #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions deploy/kubernetes/csi-snapshotter/setup-csi-snapshotter.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ spec:
serviceAccount: csi-snapshotter
containers:
- name: csi-provisioner
image: quay.io/k8scsi/csi-provisioner:v1.5.0-rc1
image: quay.io/k8scsi/csi-provisioner:v1.5.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the other repos, we use "latest" tag so we don't need to remember to update it every release

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I want to backport this to release-2.0 branch. Do you suggest to submit a PR directly to the release-2.0 branch?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is a strange example because in other sidecar repos, the deployment is not a complete/workable spec and the expectation is to go to the hostpath driver repo to look at a real example with fixed versions

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to provide an example here so people can test create snapshot easily without deploying a full blown setup as in the hostpath driver repo. I can add a note here for people to look at that repo for full testing of all features.

args:
- "--v=5"
- "--csi-address=$(ADDRESS)"
Expand All @@ -84,8 +84,7 @@ spec:
- name: socket-dir
mountPath: /csi
- name: csi-snapshotter
# NOTE: replace with official image when released: quay.io/k8scsi/csi-snapshotter:v2.0.0
image: quay.io/k8scsi/csi-snapshotter:v2.0.0-rc4
image: quay.io/k8scsi/csi-snapshotter:v2.0.1
args:
- "--v=5"
- "--csi-address=$(ADDRESS)"
Expand Down
3 changes: 1 addition & 2 deletions deploy/kubernetes/snapshot-controller/setup-snapshot-controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ spec:
serviceAccount: snapshot-controller
containers:
- name: snapshot-controller
# NOTE: replace with official image when released: quay.io/k8scsi/snapshot-controller:v2.0.0
image: quay.io/k8scsi/snapshot-controller:v2.0.0-rc4
image: quay.io/k8scsi/snapshot-controller:v2.0.1
args:
- "--v=5"
- "--leader-election=false"
Expand Down