Make azure services async

[shysank]

/kind feature

• Add proposal for Async Azure Resource Creation and Deletion #1541 introduced a proposal to make azure service reconciliation asynchornous
• Add long running operation types, conditions, and helpers #1610 added a framework to achieve this by following a repeatable pattern

This issue aims to track individual services for the same:

• async agentpools
• async availabilitysets #1709
• async bastionhosts #1710
• async disks #1711
• async groups - Make group delete async #1667
• async inboundnatrules #1712
• async loadbalancers #1713
• async managedclusters #2140
• async natgateways #1714
• async networkinterfaces #1717
• async privatedns #1715
• async publicips #1716
• async roleassignments #1718
• async routetables - Make route tables reconcile/delete async #1686
• async scalesets refactor #2719
• async scalesetvms refactor #2720
• async securitygroups #1919
• async subnets #1708
• async tags #2142
• async virtualmachines - make virtual machine reconcile async #1697
• async virtualnetworks - Make VNet and NSGs reconcile/delete async #1684
• async vnet peerings #1829
• async vmextensions #2141

[shysank]

cc @CecileRobertMichon

[CecileRobertMichon]

thank you for opening this!

[CecileRobertMichon]

/assign

[CecileRobertMichon]

Now that's I've opened a few PRs with some examples (and once the VM one merges, since that one has a few changes in the helpers), I would love some help to get this done. Since each service is self-contained, different people can open PRs in parallel, similar to what we did for #757. We just need to communicate on this issue before starting to work on a service so two people don't work on the same one.

/help

[k8s-ci-robot]

@CecileRobertMichon:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Now that's I've opened a few PRs with some examples (and once the VM one merges, since that one has a few changes in the helpers), I would love some help to get this done. Since each service is self-contained, different people can open PRs in parallel, similar to what we did for #757. We just need to communicate on this issue before starting to work on a service so two people don't work on the same one.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[karuppiah7890]

How about we create separate GitHub issues for each service? More like sub tasks. GitHub supports that. Example - pingcap/tidb#28010 (issue) , pingcap/tidb#26747 (super issue for tracking), pingcap/tidb#26022 (super super issue for tracking)

[karuppiah7890]

Creating separate issues will avoid duplicate work or having to track assigned folks and the service they are assigned to from comments. We just have to ensure no one assigns themselves to this issue the super issue for tracking. Creating separate issues will also help us track which services are done and it can be closed by the bot when the PR is closed, using the Fixes feature, and PRs can also refer to different issues in the PR instead of the same issue

[shysank]

How about we create separate GitHub issues for each service? More like sub tasks. GitHub supports that. Example - pingcap/tidb#28010 (issue) , pingcap/tidb#26747 (super issue for tracking), pingcap/tidb#26022 (super super issue for tracking)

issue -> super issue -> super super issue, you brought me some java memories there :) On a serious note though, while I agree that having separate issues is useful in some ways (like fixes feature), I didn't want to flood the issues page with this. Having said that, I'm okay if others feel the same way of maintaining separate issues.

[CecileRobertMichon]

so converting to issues is actually just one click so I just went ahead and converted some of the ones that are ready to be picked up. For folks who want to help, please use the sub-issues to assign yourself before opening a PR for one of the services.

[CecileRobertMichon]

/assign @Jont828

[k8s-ci-robot]

@CecileRobertMichon: GitHub didn't allow me to assign the following users: Jont828.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Jont828

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Jont828]

/assign

[Jont828]

@shysank Would it be possible for me to get access to edit the issue? Was hoping to add a link to the PR for each issue that's been assigned.

[shysank]

I think you'll need to maintainer access to do that. The issues have links to pr, do you want to add the pr links here directly as well?

[CecileRobertMichon]

@Jont828 I'm going to close this one since all the services are technically "async" now, and the few remaining cleanups/refactor to adopt the same patterns are all tracked in their own issues. Great work! 🚀

/close

[k8s-ci-robot]

@CecileRobertMichon: Closing this issue.

In response to this:

@Jont828 I'm going to close this one since all the services are technically "async" now, and the few remaining cleanups/refactor to adopt the same patterns are all tracked in their own issues. Great work! 🚀

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.