Skip to content

async disks #1711

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Tracked by #1702
CecileRobertMichon opened this issue Sep 21, 2021 · 10 comments · Fixed by #1844
Closed
Tracked by #1702

async disks #1711

CecileRobertMichon opened this issue Sep 21, 2021 · 10 comments · Fixed by #1844
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@CecileRobertMichon
Copy link
Contributor

No description provided.

@CecileRobertMichon CecileRobertMichon added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 21, 2021
@karuppiah7890
Copy link
Contributor

/assign

karuppiah7890 added a commit to karuppiah7890/issues-info that referenced this issue Nov 1, 2021
Signed-off-by: Karuppiah Natarajan <karuppiah7890@users.noreply.github.com>
karuppiah7890 added a commit to karuppiah7890/issues-info that referenced this issue Nov 1, 2021
Signed-off-by: Karuppiah Natarajan <karuppiah7890@users.noreply.github.com>
@karuppiah7890
Copy link
Contributor

Finally started working on this issue 😅

@Jont828
Copy link
Contributor

Jont828 commented Nov 8, 2021

@karuppiah7890 Hey, I didn't see that you had assigned the issue and I also started working on it. Are you still working on this too?

@karuppiah7890
Copy link
Contributor

Yes @Jont828 , I have some code in my fork branch. I'm half way done I think. Not sure though

@karuppiah7890
Copy link
Contributor

karuppiah7890 commented Nov 9, 2021

The branch I'm working on is - https://github.com/karuppiah7890/cluster-api-provider-azure/tree/fix-1711 . Let me know if it makes sense to continue (it's currently on pause) or if you want to take over and complete it, in which case I can unassign myself

@Jont828
Copy link
Contributor

Jont828 commented Nov 9, 2021

Yeah I can take over and add you as coauthor. I've finished the changes involving the spec and just have to do the tests.

@karuppiah7890
Copy link
Contributor

Cool ! I was looking towards contributing and closing this issue but it's okay as I'm also caught up with a few other PRs

And I think you don't have to add me as a co author 😅 unless there's any code getting contributed from me (from my fork branch)

@karuppiah7890
Copy link
Contributor

/unassign

@Jont828
Copy link
Contributor

Jont828 commented Nov 11, 2021

Sounds good, I wrote it up on my own before I saw that the issue was taken. Thanks for understanding!

@karuppiah7890
Copy link
Contributor

/assign @Jont828

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants