Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Enhance kubeadm phase and graduate to top-level command #454

Closed
luxas opened this issue Sep 15, 2017 · 9 comments
Closed

Enhance kubeadm phase and graduate to top-level command #454

luxas opened this issue Sep 15, 2017 · 9 comments
Assignees
@neolit123 @fabriziopandini
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v1.13

Comments

@luxas
Copy link
Member

luxas commented Sep 15, 2017

For instance, support --dry-run everywhere.
@fabriziopandini had also other suggestions:

  • There probably should be a bootstrap-token all command
  • Maybe bootstrap-token create alias that would equal token create [flags]
  • Maybe something with the CA pinning stuff as well...

etc. Let's discuss the improvements here, and collect user feedback.
@luxas luxas added kind/enhancement priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 15, 2017
@luxas luxas added this to the v1.9 milestone Sep 15, 2017
@fabriziopandini
Copy link
Member

  • markmaster currently asks explicitily for node-name; probability we should implement a behaviour more similar to init > use "default" host name or the value of --node-name flag if specified + eventually support --config as well
  • bootstrap-token createconfig map currently asks for a config file, that should be kubeconfig file. This could create confusion because in all the other subcommands --config refers to the master configuration file > probably this should be simplified, using only the --kubeconfig flag

@luxas
Copy link
Member Author

luxas commented Oct 13, 2017

@fabriziopandini Can you fix the items mentioned here?

@fabriziopandini
Copy link
Member

fabriziopandini commented Oct 16, 2017 •
edited
Loading

Ok!
However, @luxas let's agree before on the final layout of bootstrap-token.
Below my proposal:

kubeadm alpha phase bootstrap-token all (new subcommand, calls all the following sub commands)
kubeadm alpha phase bootstrap-token create (new subcommand, creates the token and prints join info including CA pinning stuff as well)
kubeadm alpha phase bootstrap-token cluster-info (to be improved as described above)
kubeadm alpha phase bootstrap-token node allow-post-csrs
kubeadm alpha phase bootstrap-token node allow-auto-approve

NB. kubeadm alpha phase bootstrap-token createwill support also read from config file as requested by #461

@luxas
Copy link
Member Author

luxas commented Oct 20, 2017

@fabriziopandini That LGTM, please send the PR!

@fabriziopandini fabriziopandini mentioned this issue Nov 16, 2017
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Nov 18, 2017
Merge pull request #55903 from fabriziopandini/kubeadm-markmaster
f48b00b 
Automatic merge from submit-queue (batch tested with PRs 55233, 55927, 55903, 54867, 55940). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Enhance kubeadm markmaster

**What this PR does / why we need it**:
This PR is part of the effort for improving kubeadm phases, and more specifically improves `mark-master` phase by implementing a behaviour similar to `kubeadm init`, that is:
- dynamically initialise node name if not provided 
- allow to override with `--node-name` flag or with `--config` 

Also reference doc for `mark-master` was improved.

**Which issue(s) this PR fixes** 
part of the effort for [#454](kubernetes/kubeadm#454)
part of the effort for [#265](kubernetes/kubeadm#265)

**Special notes for your reviewer**:
Alpha disclaimer aligned to change requested on the website.

**Release note**:
```release-note
NONE
```
@fabriziopandini fabriziopandini mentioned this issue Nov 19, 2017
Merged
@luxas luxas changed the title Enhance kubeadm phase in v1.9 and graduate to top-level command Enhance kubeadm phase and graduate to top-level command Nov 20, 2017
@luxas
Copy link
Member Author

luxas commented Nov 20, 2017

Work on this has been done in v1.9, but it won't make beta quite yet

@luxas luxas modified the milestones: v1.9, v1.10 Nov 20, 2017
@timothysc timothysc modified the milestones: v1.10, v1.11 Jan 24, 2018
@fabriziopandini fabriziopandini mentioned this issue Mar 9, 2018
Closed
@fabriziopandini fabriziopandini mentioned this issue Mar 24, 2018
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 24, 2018
@luxas luxas added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/feature Categorizes issue or PR as related to a new feature. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence. labels May 14, 2018
@luxas luxas modified the milestones: v1.11, v1.12 May 14, 2018
@fabriziopandini fabriziopandini mentioned this issue Jun 15, 2018
Closed
@timothysc
Copy link
Member

@fabriziopandini will you have time this cycle to work on this?

@timothysc timothysc modified the milestones: v1.12, v1.13 Aug 29, 2018
@timothysc
Copy link
Member

/assign @neolit123

@neolit123 neolit123 mentioned this issue Sep 6, 2018
Closed
@neolit123 neolit123 added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Oct 3, 2018
@neolit123 neolit123 mentioned this issue Oct 3, 2018
Closed
@neolit123
Copy link
Member

close in favor of #454
as all the tracking is there.

also the task is almost done now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@neolit123 neolit123

@fabriziopandini fabriziopandini

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v1.13
Development

No branches or pull requests
6 participants
@timothysc @neolit123 @fabriziopandini @luxas @k8s-ci-robot @fejta-bot