Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

kubeadm token create cannot read from config file #461

Closed
mattymo opened this issue Sep 18, 2017 · 3 comments · Fixed by kubernetes/kubernetes#60059
Closed

kubeadm token create cannot read from config file #461

mattymo opened this issue Sep 18, 2017 · 3 comments · Fixed by kubernetes/kubernetes#60059
Assignees
@fabriziopandini
Labels
area/security priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triaged
Milestone
v1.10

Comments

@mattymo
Copy link

mattymo commented Sep 18, 2017

Choose one: FEATURE REQUEST

Versions

kubeadm version (use kubeadm version):v1.8.0-beta1

What happened?

kubeadm token create can only work with a specified token string. Using a config file keeps the token off of bash history.
@fabriziopandini fabriziopandini mentioned this issue Oct 16, 2017
Closed
@luxas
Copy link
Member

luxas commented Oct 20, 2017

@fabriziopandini can I assign you this?

@fabriziopandini
Copy link
Member

Yes!

@luxas luxas added this to the v1.9 milestone Oct 27, 2017
@luxas luxas added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 27, 2017
@fabriziopandini fabriziopandini mentioned this issue Nov 19, 2017
Merged
@luxas luxas modified the milestones: v1.9, v1.10 Nov 20, 2017
@timothysc
Copy link
Member

@fabianofranz will try to complete in this cycle.

@fabriziopandini fabriziopandini mentioned this issue Feb 19, 2018
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Feb 27, 2018
Merge pull request #60059 from fabriziopandini/kubeadm461
edd7a48 
Automatic merge from submit-queue (batch tested with PRs 59674, 60059, 60220, 58916, 60336). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

kubeadm token create using config file

**What this PR does / why we need it**:
Extends `kubeadm token create` adding `--config` flag. Using a config file keeps the token off of bash history.

**Which issue(s) this PR fixes**:
Fixes [#461](kubernetes/kubeadm#461)

**Special notes for your reviewer**:

**Release note**:
```release-note
NONE
```
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@fabriziopandini fabriziopandini

Labels
area/security priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triaged
Projects
None yet
Milestone
v1.10
Development

Successfully merging a pull request may close this issue.

kubeadm token create using config file fabriziopandini/kubernetes
5 participants
@timothysc @mattymo @jamiehannaford @fabriziopandini @luxas