community[patch]: Force opt-in for WebResearchRetriever (CVE-2024-3095) #24451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
eyurtsev
changed the title
dosubot
bot
added
size:M
This was referenced Jul 19, 2024
olgamurraft
pushed a commit
to olgamurraft/langchain
that referenced
this pull request
Aug 16, 2024
… (langchain-ai#24451) This PR addresses the issue raised by (CVE-2024-3095) https://huntr.com/bounties/e62d4895-2901-405b-9559-38276b6a5273 Unfortunately, we didn't do a good job writing the initial report. It's pointing at both the wrong package and the wrong code. The affected code is the Web Retriever not the AsyncHTMLLoader, and the WebRetriever lives in langchain-community The vulnerable code lives here: https://github.com/langchain-ai/langchain/blob/0bd3f4e1292c085f22bef1fff16059851e11d042/libs/community/langchain_community/retrievers/web_research.py#L233-L233 This PR adds a forced opt-in for users to make sure they are aware of the risk and can mitigate by configuring a proxy: https://github.com/langchain-ai/langchain/blob/0bd3f4e1292c085f22bef1fff16059851e11d042/libs/community/langchain_community/retrievers/web_research.py#L84-L84
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue raised by (CVE-2024-3095)
https://huntr.com/bounties/e62d4895-2901-405b-9559-38276b6a5273
Unfortunately, we didn't do a good job writing the initial report. It's pointing at both the wrong package and the wrong code.
The affected code is the Web Retriever not the AsyncHTMLLoader, and the WebRetriever lives in langchain-community
The vulnerable code lives here:
langchain/libs/community/langchain_community/retrievers/web_research.py
Line 233 in 0bd3f4e
This PR adds a forced opt-in for users to make sure they are aware of the risk and can mitigate by configuring a proxy:
langchain/libs/community/langchain_community/retrievers/web_research.py
Line 84 in 0bd3f4e