Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Ensure ordering of astradb inputs #4552

Merged
merged 4 commits into from
Nov 12, 2024
Merged

fix: Ensure ordering of astradb inputs #4552

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fcf481
fix: Ensure ordering of astradb inputs
erichare Nov 12, 2024
236ac03
Merge branch 'main' into fix-ordering-astradb-inputs
erichare Nov 12, 2024
1b6417f
Merge branch 'main' into fix-ordering-astradb-inputs
erichare Nov 12, 2024
d4a1772
Merge branch 'main' into fix-ordering-astradb-inputs
erichare Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/backend/base/langflow/components/vectorstores/astradb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class AstraVectorStoreComponent(LCVectorStoreComponent):
advanced=True,
),
DropdownInput(
name="embedding_service",
name="embedding_choice",
display_name="Embedding Model or Astra Vectorize",
info="Determines whether to use Astra Vectorize for the collection.",
options=["Embedding Model", "Astra Vectorize"],
Expand Down Expand Up @@ -239,7 +239,7 @@ def insert_in_dict(self, build_config, field_name, new_parameters):
return build_config

def update_build_config(self, build_config: dict, field_value: str, field_name: str | None = None):
if field_name == "embedding_service":
if field_name == "embedding_choice":
if field_value == "Astra Vectorize":
self.del_fields(build_config, ["embedding"])

Expand All @@ -252,7 +252,7 @@ def update_build_config(self, build_config: dict, field_value: str, field_name:
real_time_refresh=True,
).to_dict()

self.insert_in_dict(build_config, "embedding_service", {"embedding_provider": new_parameter})
self.insert_in_dict(build_config, "embedding_choice", {"embedding_provider": new_parameter})
else:
self.del_fields(
build_config,
Expand All @@ -273,7 +273,7 @@ def update_build_config(self, build_config: dict, field_value: str, field_name:
info="Allows an embedding model configuration.",
).to_dict()

self.insert_in_dict(build_config, "embedding_service", {"embedding": new_parameter})
self.insert_in_dict(build_config, "embedding_choice", {"embedding": new_parameter})

elif field_name == "embedding_provider":
self.del_fields(
Expand Down Expand Up @@ -410,7 +410,7 @@ def build_vector_store(self, vectorize_options=None):
msg = f"Invalid setup mode: {self.setup_mode}"
raise ValueError(msg) from e

if self.embedding_service == "Embedding Model":
if self.embedding_choice == "Embedding Model":
embedding_dict = {"embedding": self.embedding}
else:
from astrapy.info import CollectionVectorServiceOptions
Expand Down
Loading