Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[9.x] Make Vite::hotFile() public #43875

Merged
merged 1 commit into from
Aug 26, 2022
Merged

[9.x] Make Vite::hotFile() public #43875

merged 1 commit into from
Aug 26, 2022

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Aug 26, 2022

Hey!

I often encounter the Problem while developing that I run into an error and then I need to manually reload the page after correcting the error. Using ViteJS it is already possible to reload the page automatically on file save and I would love it, if there is a way for auto reloading the error page to check if the code is running correctly.

For that I added the ability to add custom HTML to the error page in spatie/ignition#161

There is already a followup PR for adding the Vite Reload Script to the Error Page Head in spatie/laravel-ignition#110

While doing the PR I saw, that the hotFile method is protected, which is needed for detecting the correct file path. (Otherwise only a fallback to the public path hot-file is possible)

This PR makes the hotFile method public.

@Jubeki Jubeki changed the title [9.x] Make hotFile() public for Vite [9.x] Make Vite::hotFile() public Aug 26, 2022
@taylorotwell taylorotwell merged commit 0d936a9 into laravel:9.x Aug 26, 2022
@Jubeki Jubeki deleted the make-hotfile-public-for-vite branch August 28, 2022 15:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants