Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add vitejs autorefresh to error page #110

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Aug 26, 2022

Hey!

I often encounter the Problem while developing that I run into an error and then I need to manually reload the page after correcting the error. Using ViteJS it is already possible to reload the page automatically on file save and I would love it, if there is a way for auto reloading the error page to check if the code is running correctly.

For that I added the ability to add custom HTML to the error page in spatie/ignition#161

This PR is a follow up for adding the ViteJS script for reloading the page to the error page.

Originally discussed in spatie/ignition#155

Note
PR: laravel/framework#43875 was merged into laravel/framework so that the method hotFile is public instead of protected. It will probably be released in v9.27.0

src/Renderers/ErrorPageRenderer.php Outdated Show resolved Hide resolved
src/Renderers/ErrorPageRenderer.php Outdated Show resolved Hide resolved
@Jubeki Jubeki marked this pull request as ready for review August 28, 2022 16:34
@Jubeki Jubeki requested a review from freekmurze September 16, 2022 12:25
@freekmurze freekmurze merged commit 192962f into spatie:main Sep 16, 2022
@freekmurze
Copy link
Member

Thank you for this awesome feature!

@Jubeki Jubeki deleted the add-vitejs-autorefresh branch September 16, 2022 13:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants