[11.x] PHP 8.4 build #52633
Closed
[11.x] PHP 8.4 build #52633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds now fail due to a Redis issue: |
|
725 deprecations, 10 errors and 8 failures on the PHPUnit v11 build 👀 |
* Fix implicit null types * Update some lower requirements * Fix typo * More lower version constraints * More lower version constraints * For now only run lowest strategy * Adjust PHPunit version * Adjust carbon requirement * Add phpunit 10 again * Fix phpunit annotations * Add prefer-stable again, disable fail-fast * Allow cli-parser 2.0.1 for phpunit 10 * Escape pipe
* Update sebastian/exporter * Update dependencies for PHP 8.4 * Update dependencies for PHP 8.4 * Update dependencies for PHP 8.4 * run both phpunits version on lowest and stable again * Disable fail-fast * Update required predis/predis * Bump vlucas/phpdotenv * bump guzzlehttp/promises * Bump league/flysystem * wip * wip * wip --------- Co-authored-by: Dries Vints <dries@vints.be>
This reverts commit 4192402.
Jubeki
reviewed
Oct 24, 2024
Co-authored-by: Julius Kiekbusch <contact@julius-kiekbusch.de>
|
@driesvints i just bumped |
3 tasks
ffakira
reviewed
Nov 16, 2024
| matrix: | ||
| php: [8.2, 8.3] | ||
| phpunit: ['10.5', '11.0.1'] | ||
| php: [8.4] |
There was a problem hiding this comment.
Is there any specific reason why would only support PHP 8.4? Instead just appending to the versioning matrix to include [8.2, 8.3, 8.4].
There was a problem hiding this comment.
This is only a temporary testing solution. This is done, so that only the PHP 8.4 tests are running. These PHP versions will be added again after PHP 8.4 tests are passing.
|
Replaced with #53468 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by:
nette/schema: Tag for PHP 8.4 support nette/schema#68voku/portable-ascii: Deprecated voku in php8.4alpha1 voku/portable-ascii#101predis/predis2.2.3 or 2.3.0: https://github.com/predis/predis/releasesaws/aws-sdk-php: fix: PHP 8.4 deprecations with implicit nullable parameters aws/aws-sdk-php#2995fakerphp/faker: PHP 8.4 Support FakerPHP/Faker#904dragonmantank/cron-expression: Add PHP 8.4 Support dragonmantank/cron-expression#190