Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revert select component #488

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Revert select component #488

merged 1 commit into from
Jun 17, 2020

Conversation

nevalla
Copy link
Contributor

@nevalla nevalla commented Jun 17, 2020

Fix regression from #450

@nevalla
Revert select component
f4946d9 
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
@nevalla nevalla added the bug Something isn't working label Jun 17, 2020
@nevalla nevalla added this to the 3.5.1 milestone Jun 17, 2020
@nevalla nevalla requested a review from Nokel81 June 17, 2020 11:57
Nokel81
Nokel81 approved these changes Jun 17, 2020
View reviewed changes
Copy link
Collaborator

@Nokel81 Nokel81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, it wasn't building for me without this. But looks good anyhow.

@nevalla nevalla merged commit f597afb into master Jun 17, 2020
@nevalla nevalla deleted the revert-select-component branch June 17, 2020 20:18
nevalla added a commit that referenced this pull request Jun 24, 2020
@nevalla
Revert select component (#488)
89e7764 
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
This was referenced Jun 24, 2020
Merged
Merged
@jakolehm jakolehm mentioned this pull request Jul 1, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Nokel81 Nokel81 Nokel81 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nevalla @Nokel81