Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert select component #488

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Revert select component #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dashboard/client/components/select/select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import ReactSelect, { components as ReactSelectComponents } from "react-select"
import { Props as ReactSelectProps } from "react-select/base"
import Creatable, { CreatableProps } from "react-select/creatable"
import { StylesConfig } from "react-select/src/styles"
import { ActionMeta, OptionTypeBase } from "react-select/src/types"
import { ActionMeta } from "react-select/src/types"
import { themeStore } from "../../theme.store";

export { ReactSelectComponents }
Expand All @@ -31,7 +31,7 @@ export interface SelectProps<T = any> extends ReactSelectProps<T>, CreatableProp
menuClass?: string;
isCreatable?: boolean;
autoConvertOptions?: boolean; // to internal format (i.e. {value: T, label: string}[]), not working with groups
onChange?(option: T, meta?: ActionMeta<OptionTypeBase>): void;
onChange?(option: T, meta?: ActionMeta): void;
}

@observer
Expand Down Expand Up @@ -76,7 +76,7 @@ export class Select extends React.Component<SelectProps> {
}

@autobind()
onChange(value: SelectOption, meta: ActionMeta<OptionTypeBase>) {
onChange(value: SelectOption, meta: ActionMeta) {
if (this.props.onChange) {
this.props.onChange(value, meta);
}
Expand Down