Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Broaden a pylint ignore. #1029

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Broaden a pylint ignore. #1029

merged 1 commit into from
Mar 11, 2022

Conversation

petervdonovan
Copy link
Collaborator

This is just a one-line patch. I am not sure why it's necessary (it worked before!), but it seems harmless in the sense that it won't conceal any errors that would otherwise have been detected.

This change has been tested in Epoch.

@petervdonovan petervdonovan linked an issue Mar 10, 2022 that may be closed by this pull request
@petervdonovan petervdonovan merged commit 8c3343b into master Mar 11, 2022
@petervdonovan petervdonovan deleted the fix-1027 branch March 11, 2022 00:00
@Soroosh129
Copy link
Contributor

Could it be, perhaps, that somehow the installed Python module for a Python-target program (which is installed via pip) cannot be discovered within the Epoch environment?

@petervdonovan
Copy link
Collaborator Author

petervdonovan commented Mar 11, 2022

Could it be, perhaps, that somehow the installed Python module for a Python-target program (which is installed via pip) cannot be discovered within the Epoch environment?

I do not think that the Python module needed to be installed in order for Pylint to work. The Pylint check was supposed to be fast, and installing the module was one of the slowest parts of compilation. Therefore, if the module is required, then there is a bug.

But you're right, I probably did not test things thoroughly or at all in Epoch. It could have something to do with that.

@lhstrh lhstrh added the bug Something isn't working label Mar 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epoch fails on valid file
3 participants