Do not minimize the shadow jar #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #1284 was caused by the mimization step of the shadowJar gradle plugin. The main problem is, that we don't import kotlin classes directly, but load them manually in order to work around the build problems in Eclipse... Hence, the minimizer thinks it can exclude the Kotlin classes. While in principle it is possible to add particular excludes, this does not work properly when we compile a second time. The reason for this is unclear, but we might as well disable the minimization. This slightly increases the jar size from 23 MB to 28 MB. Closes #1284
cmnrd
added
bug
lhstrh
requested changes
Jul 8, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1284 was caused by the mimization step of the shadowJar gradle plugin. The main problem is, that we don't import kotlin classes directly, but load them manually in order to work around the build problems in Eclipse... Hence, the minimizer thinks it can exclude the Kotlin classes. While in principle it is possible to add particular excludes, this does not work properly when we compile a second time. The reason for this is unclear, but we might as well disable the minimization. This slightly increases the jar size from 23 MB to 28 MB.
Closes #1284