Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not minimize the shadow jar #1285

Merged
merged 2 commits into from
Jul 11, 2022
+5 −5
Merged

Do not minimize the shadow jar #1285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f27565e
Do not minimize the shadow jar
cmnrd Jul 7, 2022
b0a4795
Explain why minimize is not used in shadowJar
cmnrd Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions org.lflang.lfc/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ task buildLfc() {

shadowJar {
exclude 'test/*'
minimize() {
exclude(dependency('log4j:log4j:.*'))
exclude(dependency('com.google.inject:guice:.*'))
exclude(dependency('org.lflang:org.lflang:.*'))
}
transform(com.github.jengelman.gradle.plugins.shadow.transformers.AppendingTransformer){
resource = 'plugin.properties'
}
// We should use minimize() here to reduce the size of the JAR, but it causes problems
// with regard to our Kotlin classes. Since we don't use imports to load them but load
// the classes manually, minimize does not see the dependency. While we can add an exclude
// rule, this does not seem to work very well and causes problems when compiling for a
// second time. Also see https://github.com/lf-lang/lingua-franca/pull/1285
}
}

Expand Down