Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: enable webkit tests in interop #2541

Merged
merged 8 commits into from
Feb 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ jobs:
- uses: libp2p/test-plans/.github/actions/run-interop-ping-test@master
with:
test-filter: js-libp2p-head
extra-versions: ${{ github.workspace }}/interop/node-version.json ${{ github.workspace }}/interop/chromium-version.json ${{ github.workspace }}/interop/firefox-version.json
extra-versions: ${{ github.workspace }}/interop/node-version.json ${{ github.workspace }}/interop/chromium-version.json ${{ github.workspace }}/interop/firefox-version.json ${{ github.workspace }}/interop/webkit-version.json
s3-cache-bucket: ${{ vars.S3_LIBP2P_BUILD_CACHE_BUCKET_NAME }}
s3-access-key-id: ${{ vars.S3_LIBP2P_BUILD_CACHE_AWS_ACCESS_KEY_ID }}
s3-secret-access-key: ${{ secrets.S3_LIBP2P_BUILD_CACHE_AWS_SECRET_ACCESS_KEY }}
Expand Down
4 changes: 1 addition & 3 deletions interop/Makefile
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
image_name := js-libp2p-head
TEST_SOURCES := $(wildcard test/*.ts)

# Enable webkit once https://github.com/libp2p/js-libp2p/pull/1627 is in
# all: image.json webkit-image.json firefox-image.json chromium-image.json
all: image.json firefox-image.json chromium-image.json
all: image.json firefox-image.json chromium-image.json webkit-image.json

image.json: Dockerfile $(TEST_SOURCES) package.json .aegir.js
cd .. && docker build -f interop/Dockerfile -t node-${image_name} .
Expand Down
27 changes: 16 additions & 11 deletions interop/webkit-version.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
{
"id": "webkit-js-libp2p-head",
"containerImageID": "webkit-js-libp2p-head",
"transports": [],
"secureChannels": [
"noise"
],
"muxers": [
"yamux",
"mplex"
]
}
"id": "webkit-js-libp2p-head",
"containerImageID": "webkit-js-libp2p-head",
"transports": [
{
"name": "webrtc-direct",
"onlyDial": true
},
"webrtc",
{
"name": "wss",
"onlyDial": true
}
],
"secureChannels": ["noise"],
"muxers": ["yamux", "mplex"]
}
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"test:firefox": "aegir run test:firefox",
"test:firefox-webworker": "aegir run test:firefox-webworker",
"test:electron-main": "aegir run test:electron-main",
"test:webkit": "aegir run test:webkit",
"test:cli": "aegir run test:cli",
"test:interop": "aegir run test:interop",
"coverage": "aegir run coverage",
Expand Down
1 change: 1 addition & 0 deletions packages/transport-webrtc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
"test:node": "aegir test -t node --cov -- --exit",
"test:chrome": "aegir test -t browser --cov",
"test:firefox": "aegir test -t browser -- --browser firefox",
"test:webkit": "aegir test -t browser -- --browser webkit",
"lint": "aegir lint",
"lint:fix": "aegir lint --fix",
"clean": "aegir clean",
Expand Down
Loading