chore: enable webkit tests in interop #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
requested changes
May 14, 2024
There was a problem hiding this comment.
The test:webkit script needs to be added to the root package.json as well otherwise these tests won't run.
We should see webkit appear in the transport-interop summary if this has been done correctly.
|
This is blocked until #2007 is resolved |
achingbrain
force-pushed
the
main
branch
2 times, most recently
from
6453a80 to
c2bc7fe
Compare
achingbrain
added a commit
to libp2p/test-plans
that referenced
this pull request
Feb 4, 2025
In order to test webkit interop, build docker images with the `BROWSER` build arg set to `webkit`. I think we might need this before the tests in libp2p/js-libp2p#2541 will actually run.
achingbrain
changed the title
achingbrain
changed the title
achingbrain
approved these changes
Feb 4, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
ci: enable webkit tests in interop and webRTC
Description
We had issues in the past running these tests which lead to the discovery of inadequate support in WebkitGTK
Closes #1808
Change checklist