refactor(quic): rewrite quic using quinn #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one is fresh, uses all features from master but with less code. I tried to update #2801 but it turned out it was easier to rewrite it. |
kpp
changed the title
kpp
commented
Feb 15, 2023
fix(quic/stream): return error on read
4 tasks
fix(quic/connection): await connection.closed
|
This pull request has merge conflicts. Could you please resolve them @kpp? 🙏 |
mxinden
added a commit
to mxinden/rust-libp2p-server
that referenced
this pull request
Jul 29, 2023
Most prominently, includes libp2p/rust-libp2p#3454.
4 tasks
10 tasks
mxinden
added a commit
to libp2p/test-plans
that referenced
this pull request
Aug 1, 2023
With libp2p/rust-libp2p#3454 merged we can now test the new rust-libp2p QUIC implementation based on upstream quinn directly from rust-libp2p `master`. This commit does the following in libp2p/test-plans: 1. Remove the `perf/impl/rust-libp2p-quinn` implementation. 2. Introduce the `perf/impl/rust-libp2p/master` version of the rust-libp2p implementation. We can promote the latter to a proper version on the next rust-libp2p release.
mxinden
added a commit
to libp2p/test-plans
that referenced
this pull request
Aug 1, 2023
With libp2p/rust-libp2p#3454 merged we can now test the new rust-libp2p QUIC implementation based on upstream quinn directly from rust-libp2p `master`. This commit does the following in libp2p/test-plans: 1. Remove the `perf/impl/rust-libp2p-quinn` implementation. 2. Introduce the `perf/impl/rust-libp2p/master` version of the rust-libp2p implementation. We can promote the latter to a proper version on the next rust-libp2p release.
thomaseizinger
pushed a commit
that referenced
this pull request
Aug 20, 2023
Rewrite quic using quinn instead of quinn-proto. libp2p-quic::endpoint::Driver is eliminated (and that hard quinn-proto machinery). Also: - ECN bits are handled - Support Generic Send Offload (GSO) Pull-Request: #3454.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrite quic using quinn instead of quinn-proto. libp2p-quic::endpoint::Driver is eliminated (and that hard quinn-proto machinery). Also:
Notes
This PR preserves the original API and naming.
Testing hole punching:
Links to any relevant issues
Open Questions
Change checklist
I have added tests that prove my fix is effective or that my feature worksTODOs
Get rid of BoxedFuture in connection