fix(perf): replace rust-libp2p-quinn/ with rust-libp2p/master #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With libp2p/rust-libp2p#3454 merged we can now test the new rust-libp2p QUIC implementation based on upstream quinn directly from rust-libp2p `master`. This commit does the following in libp2p/test-plans: 1. Remove the `perf/impl/rust-libp2p-quinn` implementation. 2. Introduce the `perf/impl/rust-libp2p/master` version of the rust-libp2p implementation. We can promote the latter to a proper version on the next rust-libp2p release.
|
Pending perf GitHub Action CI run: https://github.com/libp2p/test-plans/actions/runs/5727030855/job/15518628399 |
|
One can now compare |
|
Merging here since it only touches //CC @thomaseizinger |
Also //CC @kpp in case you want to see the fruits of your work. |
mxinden
added a commit
that referenced
this pull request
Aug 24, 2023
Implementation has been removed with #246.
mxinden
added a commit
that referenced
this pull request
Aug 24, 2023
Implementation has been removed with #246.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With libp2p/rust-libp2p#3454 merged we can now test the new rust-libp2p QUIC implementation based on upstream quinn directly from rust-libp2p
master.This commit does the following in libp2p/test-plans:
perf/impl/rust-libp2p-quinnimplementation.perf/impl/rust-libp2p/masterversion of the rust-libp2p implementation.We can promote the latter to a proper version on the next rust-libp2p release.