chore: add webkit to test matrix #603
Open
+56
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to test webkit interop, build docker images with the `BROWSER` build arg set to `webkit`. I think we might need this before the tests in libp2p/js-libp2p#2541 will actually run.
|
libp2p/js-libp2p#2541 has been merged, all WebKit transport-interop tests now pass apart from WebTransport so this should be good to go. |
achingbrain
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to test webkit interop, build docker images with the
BROWSERbuild arg set towebkit.I think we might need this before the tests in libp2p/js-libp2p#2541 will actually run since they can't seem to find any webkit docker images.Actually I think the webkit build step may have just been missing from the Makefile in libp2p/js-libp2p#2541