Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Shapella upgrade (capella+shanghai) #482

Merged
merged 2,261 commits into from
May 5, 2023
Merged

Shapella upgrade (capella+shanghai) #482

merged 2,261 commits into from
May 5, 2023

Conversation

arwer13
Copy link
Contributor

@arwer13 arwer13 commented Jan 10, 2023 •
edited by TheDZhon
Loading

The Lido protocol upgrade targeting the Ethereum Shanghai hardfork

image

The Shanghai/Capella upgrade for Ethereum, scheduled for March-April 2023, will introduce support for the unstaking of Ether. The ability to exit a validator and unstake associated Ether is required for the Lido protocol to build the withdrawals feature.

Context: Withdrawals for Lido on Ethereum.

Overview

Major features

  • Withdrawals support
    • In-protocol withdrawals FIFO request queue wrapped up into NFT
    • Revised protocol accounting
    • Facilitating validator exits
    • Rewards skimming
  • Staking router
    • Solid architecture and interfaces for upcoming modules
    • Upgrade NodeOperatorRegistry resembling the curated operators set
    • Levers for the NOM/DAO ops
  • Two-phase oracle with data lists
    • Polished consensus rules
    • Better gas efficiency of running oracles
    • Multistep oracle data delivery (’unlimited’ data size)

Minor features

  • Decrease the Lido and NodeOperatorRegistry contracts’ bytecode size
  • Revised/new sanity checks & single rebasing limit
  • ERC2612 (permit) support for stETH (aka ‘ERC20 signed approvals’)
  • transferSharesFrom for stETH
  • Reference initialization library following the LIP-10 scheme
  • Oracle reports 'fast lane' (soft ordering enforcement)

Resolved issues

Excluded from the scope

@folkyatina folkyatina mentioned this pull request Jan 12, 2023
Closed
avsetsin
avsetsin reviewed Jan 13, 2023
View reviewed changes
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
avsetsin
avsetsin reviewed Jan 13, 2023
View reviewed changes
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
contracts/0.8.9/WithdrawalQueue.sol Outdated Show resolved Hide resolved
TheDZhon
TheDZhon reviewed Jan 13, 2023
View reviewed changes
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
TheDZhon
TheDZhon reviewed Jan 13, 2023
View reviewed changes
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
TheDZhon
TheDZhon reviewed Jan 13, 2023
View reviewed changes
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
TheDZhon
TheDZhon reviewed Jan 13, 2023
View reviewed changes
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
TheDZhon
TheDZhon reviewed Jan 13, 2023
View reviewed changes
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
TheDZhon
TheDZhon reviewed Jan 13, 2023
View reviewed changes
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
TheDZhon
TheDZhon reviewed Jan 13, 2023
View reviewed changes
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
TheDZhon
TheDZhon reviewed Jan 13, 2023
View reviewed changes
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
TheDZhon
TheDZhon reviewed Jan 13, 2023
View reviewed changes
contracts/0.4.24/Lido.sol Outdated Show resolved Hide resolved
arwer13 and others added 27 commits May 2, 2023 08:57
@arwer13
update deploy parameters values (fastLaneLengthSlots, etc)
ef5ff7c
@bulbozaur
linter
5c229c8
@bulbozaur
Merge pull request #761 from lidofinance/feature/bytecode-verificator…
f580b81 
…-cli

Feature/bytecode verificator cli
@arwer13
add deploy parameters to deployed-mainnet.json
32222b6
@arwer13
update mainnet and fork deploy scripts
f33e63b
@arwer13
Merge branch 'shapella-scratch-deploy' of github.com:lidofinance/lido…
47e3a60 
…-dao into shapella-scratch-deploy
@arwer13
Merge pull request #635 from lidofinance/shapella-scratch-deploy
c0e00e0 
Shapella upgrade and scratch deploy
@arwer13
update deploy param: set fastLaneLengthSlots to 100
acb65d5
@arwer13
fix(deploy script): add wait for OracleDaemonConfig .set transactions
53b0f3e
@arwer13
add mainnet deployed addresses
21415b6
@arwer13
add missed lidoLocator address (proxy address)
35d8c86
@folkyatina
config for diffyscan
9dac142
@folkyatina
fix: add LidoLocator proxy and use audited commit
834cd57
@kadmil
Merge pull request #764 from lidofinance/diffyscan-config
e595ef3 
Diffyscan config for shapella upgrade
@arwer13
feat (deployed-mainnet.json): add proxyConstructorArgs fields
774393e
@arwer13
Merge branch 'feature/shapella-upgrade' of github.com:lidofinance/lid…
f814fd1 
…o-dao into feature/shapella-upgrade
@bulbozaur
batch verification
a66ee7b
@bulbozaur
add env checks
67a3875
@bulbozaur
add envs
65cb78d
@folkyatina
Merge pull request #765 from lidofinance/feature/bytecode-batch-verif…
65ccd7c 
…ication

batch verification
@bulbozaur
update calldata
e35435a
@bulbozaur
tests: fix consensus initial epoch
feca40b
@bulbozaur
resolve conflicts with develop
c5b7be8
@bulbozaur
Merge branch 'develop' into feature/shapella-upgrade
dc09151
@bulbozaur
linter
166cbdf
@bulbozaur
fix CI submodules deps
f54b1e2
@bulbozaur
update storage layout
2a3a53e
TheDZhon
TheDZhon approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going forward 🚗

@TheDZhon TheDZhon merged commit a480561 into develop May 5, 2023
@TheDZhon TheDZhon deleted the feature/shapella-upgrade branch February 6, 2024 18:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Psirex Psirex Psirex left review comments

@skozin skozin skozin left review comments

@loga4 loga4 loga4 left review comments

@avsetsin avsetsin avsetsin left review comments

@folkyatina folkyatina folkyatina left review comments

@ujenjt ujenjt ujenjt left review comments

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
next-upgrade Things to pickup for the next protocol upgrade
Projects
None yet
Milestone
No milestone