[fix] Add to dns only if machines are ready + Fix AWS sdk behavior (#639

) * Add to dns only if machines are ready * aws sdk shenanigans
linode · Jan 24, 2025 · 79231be · 79231be
1 parent 1bdf877
commit 79231be
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/cloud/scope/common.go b/cloud/scope/common.go
@@ -119,6 +119,8 @@ func CreateS3Clients(ctx context.Context, crClient K8sClient, cluster infrav1alp
 	var (
 		configOpts = []func(*awsconfig.LoadOptions) error{
 			awsconfig.WithRegion("auto"),
+			awsconfig.WithRequestChecksumCalculation(aws.RequestChecksumCalculationWhenRequired),
+			awsconfig.WithResponseChecksumValidation(aws.ResponseChecksumValidationWhenRequired),
 		}
 
 		clientOpts = []func(*s3.Options){}

diff --git a/cloud/services/domains.go b/cloud/services/domains.go
@@ -64,6 +64,9 @@ func EnsureDNSEntries(ctx context.Context, cscope *scope.ClusterScope, operation
 
 func getMachineIPs(cscope *scope.ClusterScope) (ipv4IPs, ipv6IPs []string, err error) {
 	for _, eachMachine := range cscope.LinodeMachines.Items {
+		if !eachMachine.Status.Ready {
+			continue
+		}
 		for _, IPs := range eachMachine.Status.Addresses {
 			if IPs.Type != v1beta1.MachineExternalIP {
 				continue