Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[fix] Add to dns only if machines are ready + Fix AWS sdk behavior #639

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

tchinmai7
Copy link
Contributor

@tchinmai7 tchinmai7 commented Jan 23, 2025

What this PR does / why we need it:

  1. Add nodes to the dns only when its ready
  2. pass config options to the aws sdk to turn off checksum protections.
    Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
    Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.21%. Comparing base (63f5b41) to head (d6e6c71).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   63.42%   63.21%   -0.21%     
==========================================
  Files          70       70              
  Lines        6086     6090       +4     
==========================================
- Hits         3860     3850      -10     
- Misses       1962     1976      +14     
  Partials      264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tchinmai7 tchinmai7 changed the title Add to dns only if machines are ready Add to dns only if machines are ready + Fix AWS sdk behavior Jan 23, 2025
@tchinmai7 tchinmai7 changed the title Add to dns only if machines are ready + Fix AWS sdk behavior [fix] Add to dns only if machines are ready + Fix AWS sdk behavior Jan 23, 2025
@tchinmai7 tchinmai7 merged commit 79231be into main Jan 24, 2025
12 of 13 checks passed
@tchinmai7 tchinmai7 deleted the add-dns-on-read branch January 24, 2025 19:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants