Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WIP: Supports dconfig2cpp #461

Closed
wants to merge 1 commit into from
Closed

WIP: Supports dconfig2cpp #461

wants to merge 1 commit into from

Conversation

zccrs
Copy link
Member

@zccrs zccrs commented Feb 20, 2025

@zccrs zccrs requested a review from 18202781743 February 20, 2025 13:36
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zccrs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Feb 20, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#461
@18202781743
Copy link
Contributor

这个targetProxy有必要么,需要外部传入一个dconfig object impl的话,那为啥不直接在qml中使用它,
目前应该没qml应用使用还用DConfigWrapper,

@zccrs
Copy link
Member Author

zccrs commented Feb 25, 2025

这个targetProxy有必要么,需要外部传入一个dconfig object impl的话,那为啥不直接在qml中使用它, 目前应该没qml应用使用还用DConfigWrapper,

这个不准备这样改了,原本想把 DConfigWrapper废弃,但是看到在 SettingsOption 中还有使用,所以还是要改到能用的状态。后面会换个方案改。

@zccrs
Copy link
Member Author

zccrs commented Feb 25, 2025

使用 #464 代替

@zccrs zccrs closed this Feb 25, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants