Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: using DConfig in the non-GUI thread #464

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zccrs
Copy link
Member

@zccrs zccrs commented Feb 25, 2025

The DConfig is a sync IO API, call it's API maybe block the GUI thread on the DConfigWrapper, so we need use the DConfig in a new thread.

@zccrs zccrs requested a review from 18202781743 February 25, 2025 03:09
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zccrs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Feb 25, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#464
@zccrs zccrs mentioned this pull request Feb 25, 2025
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Feb 25, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#464
The DConfig is a sync IO API, call it's API maybe block the GUI thread
on the DConfigWrapper, so we need use the DConfig in a new thread.
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Feb 25, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#464
@zccrs
Copy link
Member Author

zccrs commented Feb 25, 2025

@18202781743 你试一下功能是否ok, 另外可以模拟一下dconfig service卡死的情况(用gdb attach上去暂停它),看会不会影响GUI

@18202781743
Copy link
Contributor

@18202781743 你试一下功能是否ok, 另外可以模拟一下dconfig service卡死的情况(用gdb attach上去暂停它),看会不会影响GUI

好的,

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants