[JITLink][AArch32] Multi-stub support for armv7/thumbv7 #78371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weliveindetail
force-pushed
the
jitlink-aarch32-multi-stub
branch
from
f0f542c to
8ecdaf5
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
weliveindetail
force-pushed
the
jitlink-aarch32-multi-stub
branch
from
8ecdaf5 to
142168f
Compare
weliveindetail
force-pushed
the
jitlink-aarch32-multi-stub
branch
2 times, most recently
from
bd78a78 to
6abe2d1
Compare
weliveindetail
force-pushed
the
jitlink-aarch32-multi-stub
branch
from
6abe2d1 to
559fe8e
Compare
|
This is a pretty isolated change in JITLink AArch32. Related design questions were discussed in #78369. It seems worth landing before release/18.x branches. If there are any questions about the code here, I am happy to discuss post-commit. Pre-merge tests had passed before rebasing. |
weliveindetail
added a commit
to weliveindetail/llvm-project
that referenced
this pull request
Jan 30, 2024
This function is used in jitlink-check lines for LIT testing. In llvm#78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian.
weliveindetail
added a commit
that referenced
this pull request
Jan 30, 2024
This function is used in `jitlink-check` lines in LIT tests. In #78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian.
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Jan 30, 2024
This function is used in `jitlink-check` lines in LIT tests. In llvm#78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian. (cherry picked from commit 8a5bdd8)
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Feb 1, 2024
This function is used in `jitlink-check` lines in LIT tests. In llvm#78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian. (cherry picked from commit 8a5bdd8)
tstellar
pushed a commit
to tstellar/llvm-project
that referenced
this pull request
Feb 14, 2024
This function is used in `jitlink-check` lines in LIT tests. In llvm#78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian. (cherry picked from commit 8a5bdd8)
tstellar
pushed a commit
to tstellar/llvm-project
that referenced
this pull request
Feb 14, 2024
This function is used in `jitlink-check` lines in LIT tests. In llvm#78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian. (cherry picked from commit 8a5bdd8)
tstellar
pushed a commit
to tstellar/llvm-project
that referenced
this pull request
Feb 14, 2024
This function is used in `jitlink-check` lines in LIT tests. In llvm#78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian. (cherry picked from commit 8a5bdd8)
tstellar
pushed a commit
to tstellar/llvm-project
that referenced
this pull request
Feb 14, 2024
This function is used in `jitlink-check` lines in LIT tests. In llvm#78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian. (cherry picked from commit 8a5bdd8)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to emit stubs that match the instruction set state of the relocation site. This is important for branches that have no built-in switch for the instruction set state. It's the case for Jump24 relocations. Relocations on instructions support switching on the fly should be fixed up in a relaxation step in the future. This affects Call relocations on
BL/BLXinstructions.In this patch, the StubManager gains a second stub symbol slot for each target and selects which one to use based on the relocation type. For testing, we select the appropriate slot with a stub-kind filter, i.e.
armorthumb. With that we implements Armv7 stubs and test that we can have both kinds of stubs for a single external symbol.