[llvm-jitlink] Fix detectStubKind() for big endian systems #79970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is used in jitlink-check lines for LIT testing. In llvm#78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian.
|
The issue was reported here: sx-aurora-dev/llvm-project@e5ca202#commitcomment-137959902 |
weliveindetail
referenced
this pull request
in sx-aurora-dev/llvm-project
Jan 30, 2024
We want to emit stubs that match the instruction set state of the relocation site. This is important for branches that have no built-in switch for the instruction set state. It's the case for Jump24 relocations. Relocations on instructions that support switching on the fly will be rewritten in a relaxation step in the future. This affects Call relocations on `BL`/`BLX` instructions. In this patch, the StubManager gains a second stub symbol slot for each target and selects which one to use based on the relocation type. For testing, we select the appropriate slot with a stub-kind filter, i.e. `arm` or `thumb`. With that we can implement Armv7 stubs and test that we can have both kinds of stubs for a single external symbol.
|
FYI: The pre-merge build failed because the Windows bot is broken. |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Jan 30, 2024
This function is used in `jitlink-check` lines in LIT tests. In llvm#78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian. (cherry picked from commit 8a5bdd8)
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Feb 1, 2024
This function is used in `jitlink-check` lines in LIT tests. In llvm#78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian. (cherry picked from commit 8a5bdd8)
tstellar
pushed a commit
to tstellar/llvm-project
that referenced
this pull request
Feb 14, 2024
This function is used in `jitlink-check` lines in LIT tests. In llvm#78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian. (cherry picked from commit 8a5bdd8)
tstellar
pushed a commit
to tstellar/llvm-project
that referenced
this pull request
Feb 14, 2024
This function is used in `jitlink-check` lines in LIT tests. In llvm#78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian. (cherry picked from commit 8a5bdd8)
tstellar
pushed a commit
to tstellar/llvm-project
that referenced
this pull request
Feb 14, 2024
This function is used in `jitlink-check` lines in LIT tests. In llvm#78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian. (cherry picked from commit 8a5bdd8)
tstellar
pushed a commit
to tstellar/llvm-project
that referenced
this pull request
Feb 14, 2024
This function is used in `jitlink-check` lines in LIT tests. In llvm#78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian. (cherry picked from commit 8a5bdd8)
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is used in
jitlink-checklines in LIT tests. In #78371 I missed to swap initial instruction bytes for systems that store the constants as big-endian.