Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "Continue JS -> TS conversion" #440

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

grunch
Copy link
Member

@grunch grunch commented Oct 19, 2023

Reverts #435

Hi @Mersho I have to revert this PR because I found several errors, here are some logs.

I mostly see this kind of error with every action we do with the bot, so you will have no problem to replicated them.

[2023-10-19T12:23:28.452-03:00] error: 400: Bad Request: message identifier is not specified Error: 400: Bad Request: message identifier is not specified
    at Telegram.callApi (/home/grunch/dev/p2plnbot/node_modules/telegraf/lib/core/network/client.js:294:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[2023-10-19T12:23:29.093-03:00] error: 400: Bad Request: message text is empty Error: 400: Bad Request: message text is empty
    at Telegram.callApi (/home/grunch/dev/p2plnbot/node_modules/telegraf/lib/core/network/client.js:294:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[2023-10-19T12:24:29.439-03:00] error: 400,ExpectedIdOfInvoiceToCancel 
[2023-10-19T12:24:29.541-03:00] error: logger.error is not a function TypeError: logger.error is not a function
    at cancelOrder (/home/grunch/dev/p2plnbot/bot/commands.js:651:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[2023-10-19T12:25:20.601-03:00] error: Unhandled Rejection: TypeError: logger.error is not a function 
[2023-10-19T12:25:44.169-03:00] error: 400: Bad Request: message identifier is not specified Error: 400: Bad Request: message identifier is not specified
    at Telegram.callApi (/home/grunch/dev/p2plnbot/node_modules/telegraf/lib/core/network/client.js:294:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[2023-10-19T12:26:00.014-03:00] error: 400,ExpectedIdOfInvoiceToCancel 
[2023-10-19T12:26:00.075-03:00] error: logger.error is not a function TypeError: logger.error is not a function
    at cancelAddInvoice (/home/grunch/dev/p2plnbot/bot/commands.js:334:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

@grunch grunch merged commit 62fd089 into main Oct 19, 2023
@grunch grunch deleted the revert-435-convert-js-squashed branch October 19, 2023 15:34
@Mersho
Copy link
Contributor

Mersho commented Oct 26, 2023

Hi @grunch

Could you assist me in resolving this issue?

It would be great if you could help me understand which action causes the error, because I have some fixes but I'm not 100% sure they'll work without any issues.

Mersho added a commit to Mersho/bot that referenced this pull request Oct 26, 2023
@grunch
Copy link
Member Author

grunch commented Oct 30, 2023

TBH I just got these errors on testing, I'm not sure the origin of it, I think an easy way of find the error is to split the old PR in smaller PRs, so we can test and merge until we find the root cause, can you start creating smaller PRs of the Continue JS -> TS conversion PR?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants