Continue JS -> TS conversion #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am investigating the CI issue. Feel free to offer me any suggestions. |
Also replace "require" with "import" and "module.exports" with "export".
We need to enable esModuleInterop to solve error TS1192: ``` error TS1192: Module '"tls"' has no default export. ```
The languageModel & fiatModel interface created to type-check the data and ensure that it conforms to the expected structure and format. This can help you avoid errors and bugs when working with the data in your code. This commit enables resolveJsonModule to import module with '.json' extension.
The --downlevelIteration flag is a TypeScript compiler option that enables support for iterating over new concepts like Map, Set, or Generator in older JavaScript runtimes. By default, TypeScript targets ES3, which does not support these features. If you use a for...of loop or a spread operator on an iterable object, you may get an error. Use Date instead of Date.toISOString cause paid_at has type Date and during the conversion from js to ts, we got compilation errors.
Mersho
force-pushed
the
convert-js-squashed
branch
from
b8836a0 to
c1cf28c
Compare
thanks for this great contribution, not a clue on the ci issue, if it's too hard to find the ci issue maybe splitting this PR would be a good way to know where is the problem |
Mersho
force-pushed
the
convert-js-squashed
branch
2 times, most recently
from
8d58871 to
dea18cd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Using null instead of a boolean/undefined type is better.
I had to change the '|', otherwise typescript would complain this error msg: ``` The '|' operator is not allowed for boolean types. Consider using '||' instead. ```
|
My attempts to change regex to solve exponential backtracking failed, so I am reverting the commits. |
Mersho
force-pushed
the
convert-js-squashed
branch
2 times, most recently
from
13981f5 to
068e439
Compare
|
This PR #436 helped me identify the problem and should also be merged. CI is green, everything seems to be fine. |
grunch
added a commit
that referenced
this pull request
Oct 19, 2023
Mersho
added a commit
to Mersho/bot
that referenced
this pull request
May 15, 2024
This commit completes the TypeScript conversion [1] by replacing the CommonJS `require` syntax with TypeScript's `import` syntax. [1]: lnp2pBot#435
grunch
pushed a commit
that referenced
this pull request
May 16, 2024
This commit completes the TypeScript conversion [1] by replacing the CommonJS `require` syntax with TypeScript's `import` syntax. [1]: #435
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.