messages: CommonJS require to TypeScript import #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was already a messages.ts file, so it was already TypeScript. Please explain what this PR is doing then? |
Mersho
changed the title
"Fixing types & import/exports" is not enough explanation. What are you fixing? |
This commit completes the TypeScript conversion [1] by replacing the CommonJS `require` syntax with TypeScript's `import` syntax. [1]: lnp2pBot#435
Mersho
force-pushed
the
ConvertJsToTs-messages
branch
from
ecde801 to
488d5e9
Compare
Mersho
changed the title
@knocte Hey, thank you for noticing, I edited the PR title and the commit message, is everything all right now? |
Mersho
changed the title
|
LGTM |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit completes the TypeScript conversion 1 by replacing
the CommonJS
requiresyntax with TypeScript'simportsyntax.