Only split the signed message in to 2 parts with the message verifier. …

…Fixes #1595 (#1596)
luckyframework · Oct 29, 2021 · b30040a · b30040a
1 parent 74c049f
commit b30040a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/spec/lucky/support/message_verifier_spec.cr b/spec/lucky/support/message_verifier_spec.cr
@@ -0,0 +1,9 @@
+require "../../spec_helper"
+
+describe Lucky::MessageVerifier do
+  it "is valid" do
+    verifier = Lucky::MessageVerifier.new("supersecretsquirrel", :sha256)
+    signed_message = verifier.generate("abc123")
+    verifier.verified(signed_message).should eq("abc123")
+  end
+end
diff --git a/src/lucky/support/message_verifier.cr b/src/lucky/support/message_verifier.cr
@@ -11,7 +11,7 @@ module Lucky
     end
 
     def verified(signed_message : String) : String?
-      data, digest = signed_message.split("--")
+      data, digest = signed_message.split("--", 2)
       if valid_message?(data, digest)
         String.new(decode(data))
       end
@@ -25,7 +25,7 @@ module Lucky
     end
 
     def verify_raw(signed_message : String) : Bytes
-      data, digest = signed_message.split("--")
+      data, digest = signed_message.split("--", 2)
       if valid_message?(data, digest)
         decode(data)
       else